Add Nexus workflow #178
Merged
Add Nexus workflow #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
force-pushed
the
nexus-workflow
branch
from
ebe9c53 to
c006afa
Compare
jl-wynen
reviewed
Jun 10, 2025
src/ess/powder/conversion.py
Outdated
|
|
||
| def convert_monitor_to_wavelength( | ||
| monitor: MonitorTofData[RunType, MonitorType], | ||
| monitor: MonitorTofData[RunType, MonitorType], wavelength: WavelengthBins |
There was a problem hiding this comment.
Suggested change
| monitor: MonitorTofData[RunType, MonitorType], wavelength: WavelengthBins | |
| monitor: MonitorTofData[RunType, MonitorType], wavelength_bins: WavelengthBins |
src/ess/powder/conversion.py
Outdated
| Monitor data with time-of-flight coordinate. | ||
| wavelength: | ||
| Bins for the wavelength coordinate. This will be used ONLY if the monitor is | ||
| recorded in event mode. For histogrammed monitors no rebinning is performed. |
There was a problem hiding this comment.
Why do you histogram in this function? It seems surprising to me that the conversion function / provider does this. If this is because of the streaming workflow, could you move the histogramming into the accumulator?
There was a problem hiding this comment.
Hmmm, good idea, we could make a custom accumulator that uses given wavelength bins. I'll try that.
There was a problem hiding this comment.
Reverted this now.
Add WavelengthBins for event mode monitor binning Add docstring
This reverts commit 8790b37.
SimonHeybrock
force-pushed
the
nexus-workflow
branch
from
c006afa to
7ef1c5d
Compare
jl-wynen
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Nexus-file-based workflow. I needed this for being able to run stream processing for live data reduction.