Skip to content

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Jul 1, 2025

Check for bin edge coord when masking to avoid having masks on edges.

@nvaytet nvaytet requested a review from SimonHeybrock July 1, 2025 12:26
Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do we have any tests that use masks or could this change silently break sth.?

@nvaytet
Copy link
Member Author

nvaytet commented Jul 1, 2025

It seems all the masks were being applies on events, so this was not being tested?

It also seems that the masks like tof or wavelength masks are not applied to the monitors?
Screenshot_20250701_165327

It also doesn't appear to be hidden inside the code that does the normalization?

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Jul 2, 2025

It seems all the masks were being applies on events, so this was not being tested?

It also seems that the masks like tof or wavelength masks are not applied to the monitors? Screenshot_20250701_165327

It also doesn't appear to be hidden inside the code that does the normalization?

See #166... but I think I tried to fix that in #176, maybe it should have been closed, unless there are more cases?

@nvaytet
Copy link
Member Author

nvaytet commented Jul 2, 2025

Not sure I fully followed. In the normalization there, it seems to be relying on nanmin/max of coords, but it doesn't seem to be taking wavelength masks into account?

In the case of binned data, it's getting the hi/lo from nanmin on the event coords, not taking any masks into account?

@nvaytet nvaytet merged commit c9c29dd into main Jul 11, 2025
4 checks passed
@nvaytet nvaytet deleted the edge-masks branch July 11, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants