Add DREAM instrument view #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
approved these changes
Mar 13, 2024
src/ess/dream/instrument_view.py
Outdated
|
|
||
| import plopp as pp | ||
| import scipp as sc | ||
| from plopp.widgets import Box |
Member
There was a problem hiding this comment.
This now makes ipywidgets a hard dependency of the package, but I guess it's fine as we already have pythreejs as a dependency in the pyproject.toml
Member
Author
There was a problem hiding this comment.
Made the import conditional.
nvaytet
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40