Skip to content

Conversation

@celinedurniak
Copy link
Collaborator

The csv loader for DREAM was changed by adding support for the SANS detector.

New test data can be found at https://project.esss.dk/nextcloud/index.php/s/i2iD2M2EHD4rRnM
It corresponds to the following case:

  • sample: Si powder
  • High flux configuration of the instrument
  • Detectors: mantle with 7 modules, endcap backward and forward with 13 modules and complete layouts for High-resolution and SANS detectors

@celinedurniak celinedurniak requested a review from jl-wynen April 2, 2024 13:52
@jl-wynen
Copy link
Member

jl-wynen commented Apr 2, 2024

Thanks! I will add the new test data tomorrow

@jl-wynen
Copy link
Member

jl-wynen commented Apr 3, 2024

@celinedurniak I fixed the broken test, added more tests using the new file, and switched to using this file in the instrument view docs. Can you have a look if this all makes sense? (You have a 👍 for your changes.)

@nvaytet
Copy link
Member

nvaytet commented Apr 25, 2024

@celinedurniak gentle reminder about this ;-)

Copy link
Collaborator Author

@celinedurniak celinedurniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this pull request can be merged.

@jl-wynen jl-wynen enabled auto-merge April 29, 2024 07:08
@jl-wynen jl-wynen merged commit 07ad732 into main Apr 29, 2024
@jl-wynen jl-wynen deleted the add-sans-in-loader branch April 29, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants