Exclude detectors w/o data in load_geant4_csv #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+152
to
153
| if len(events) == 0: | ||
| return None |
Member
There was a problem hiding this comment.
Won't downstream code break if some detectors are missing/none?
Member
Author
There was a problem hiding this comment.
Isn't this is how the nexus loader behaves?
Stuff may break but it seems cleaner to not include a detector in the group if the file also didn't include it.
SimonHeybrock
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation includes all detectors in the output even if they are not present in the file. This is because of how the data is grouped.
Found in #47.