Use ess.reduce.uncertainty #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jul 10, 2024
| UncertaintyBroadcastMode = Enum( | ||
| "UncertaintyBroadcastMode", ["drop", "upper_bound", "fail"] | ||
| ) | ||
| UncertaintyBroadcastMode = _UncertaintyBroadcastMode |
Member
There was a problem hiding this comment.
How is this shown in a graph? In particular in the JSON format. Does it use ess.powder or ess.reduce as the module?
Member
Author
There was a problem hiding this comment.
Looks fine?
... but I don't know if it will still be if we include the module name?
Member
There was a problem hiding this comment.
... but I don't know if it will still be if we include the module name?
That is my point.
But we can leave it as is for now and see how it works out.
jl-wynen
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37.