Add NeXus loading helpers #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Aug 7, 2024
src/ess/powder/nexus.py
Outdated
| - The high-resolution and SANS detectors have a very odd numbering scheme. | ||
| The scheme attempts to follows some sort of physical ordering in space (x,y,z), | ||
| but it is not possible to reshape the data into all the logical dimensions. | ||
| """ |
Member
There was a problem hiding this comment.
This docstring seems to be in the wrong file.
src/ess/powder/nexus.py
Outdated
| definitions = snx.base_definitions() | ||
| definitions["NXdetector"] = FilteredDetector | ||
| # Events will be loaded later. Should we set something else as data instead, or | ||
| # use different NeXus definitions to completely bypass the (empty) event load? |
Member
There was a problem hiding this comment.
You used this already for monitors. Why not here?
jl-wynen
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on a release of scipp/scippnexus#221 so CI will fail for now.
Fixes #77.
In ESSsans there is another intermediate step, adding source+sample position before adding event data, I was not sure if it makes sense the split this out here.
It is quite apparent that there is a lot of duplication of code that is in ESSsans, but currently this is required since we have per-technique
RunTypeandMonitorType. If we could agree on a universal set it might be possible to move some of this intoessreduce, but I am not sure for now. Or maybe someone has a better idea?