Use essreduce nexus workflow #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Aug 26, 2024
tests/dream/geant4_reduction_test.py
Outdated
| assert sc.identical(result.coords['dspacing'], params[DspacingBins]) | ||
| assert sc.allclose(result.coords['two_theta'], params[TwoThetaBins]) | ||
| assert sc.identical(result.coords['dspacing'], workflow.compute(DspacingBins)) | ||
| assert sc.allclose(result.coords['two_theta'], workflow.compute(TwoThetaBins)) |
Member
There was a problem hiding this comment.
I prefer the old implementation because if checks that the workflow respects the parameters. The new tests only check that the workflow's outputs are consistent.
Member
Author
There was a problem hiding this comment.
Refactored, see update.
Co-authored-by: Jan-Lukas Wynen <jan-lukas.wynen@ess.eu>
jl-wynen
approved these changes
Aug 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent additions in #78 have mostly been moved into ESSreduce. We can thus remove them here, and forward to ESSreduce.
Also renamed
EmptyCanRun->BackgroundRunandEmptyInstrumentRun->EmptyBeamRun. While we do not have actual scientist feedback on this I think using common names is important. I expect some future back and forth on the actual names (e.g., isBackgroundRuna good name?), but I hope that can be a global discussion across techniques, i.e., we would rename the types in ESSreduce in that case.The Geant4 loader sees some small changes, partially relying on the providers from the NeXus workflow, but overriding some details.
Depends on an releases of scipp/essreduce#81,
CI here will fail for now.