feat: maximum resolution finder #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
requested changes
Sep 5, 2025
Comment on lines
49
to
50
| upper_nx = 10000 | ||
| upper_ny = 10000 |
Member
There was a problem hiding this comment.
We don't need this much of resolution. 2048 should be enough.
Contributor
Author
There was a problem hiding this comment.
Is 2048 the maximum resolution?
Contributor
Author
There was a problem hiding this comment.
Made them keyword arguments with default value 2048
|
|
||
| def test_finds_maximum_resolution(): | ||
| events = sc.DataArray( | ||
| sc.ones(dims=['events'], shape=(100,)), |
Member
There was a problem hiding this comment.
The example data should also probably have unit of counts...?
Contributor
Author
There was a problem hiding this comment.
The method doesn't do anything to the values of the data, it only checks how many of them falls into each bin, so the units don't matter.
Member
There was a problem hiding this comment.
events should have unit of counts but it shouldn't affect the test I guess...
YooSunYoung
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83