Skip to content

Conversation

@jokasimr
Copy link
Contributor

@jokasimr jokasimr commented Sep 4, 2025

Fixes the failing essimaging lower bound tests.

jupyterlab
pip-compile-multi
pre-commit
prompt-toolkit>=3.0.52
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this had to be added, but tox -e deps did not finish without it.

@github-project-automation github-project-automation bot moved this to In progress in Development Board Sep 4, 2025
@jokasimr jokasimr moved this from In progress to Selected in Development Board Sep 4, 2025
@nvaytet
Copy link
Member

nvaytet commented Sep 5, 2025

Can you remind me what is "the failing essimaging lower bound tests" ?
Thanks :-)

@jokasimr
Copy link
Contributor Author

jokasimr commented Sep 5, 2025

It's the third badge in the entries in this table: https://github.com/scipp/ess-project?tab=readme-ov-file#ess-1

You see there that for essimaging the tests are failing, that's because it uses an argument that was introduced in scipp 25.03.

@jokasimr jokasimr requested a review from nvaytet September 8, 2025 07:09
@jokasimr jokasimr merged commit 0c58598 into main Sep 9, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Selected to Done in Development Board Sep 9, 2025
@jokasimr jokasimr deleted the fix-deps branch September 9, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants