Move Ymir-related code to its own subfolder #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, api docs aren't being picked up https://remote-unzip.deno.dev/scipp/essimaging/artifacts/4208659116/api-reference/index.html |
Member
Author
|
Nice catch! Thanks for noticing |
MridulS
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we move all of the Ymir and image normalization code to the Ymir subfolder.
Some things are specific to Ymir, some things are to be replaced by
scitiff.Loading different time ranges that correspond to dark frame, open beam and sample seems to be specific to Ymir and Odin-orca. Timepix3 will record separate files for these, TBL will also record separate files for these.
So to start with, we just move them out of the generic imaging folder and into the
ymirsubfolder to avoid breaking too many things.The idea is next to start building a generic part of the image normalization workflow, which would be added to an instrument-specific part that loads the sample, open-beam and dark images (either from a single file or separate files).
We defer this work to a later PR.