-
Notifications
You must be signed in to change notification settings - Fork 1
Image normalization workflow for TBL/Orca #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ca detector (which will be different from timepix3 which is event based)
… and normalized by open beam
src/ess/tbl/orca.py
Outdated
|
|
||
| wf = GenericNeXusWorkflow( | ||
| run_types=[SampleRun, OpenBeamRun, DarkBackgroundRun], | ||
| # Abusing the monitor_types to load proton charge and exposure time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: I couldn't figure out how to cleanly load a custom field from the file. Help welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'll need functionality, or just extend the workflow by hand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make a quick outline for how you would extend the workflow by hand?
I'm not sure I understood how it would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean was to simple make new providers for additional components from scratch (possible using existing helpers).
SimonHeybrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There are some bits that seem like generic workflow components, such as the "normalize sample and background, then subtract" bit. It is pretty simply but may be worth to consider to have this as a generic workflow building block in essreduce at some point?
src/ess/tbl/orca.py
Outdated
|
|
||
| wf = GenericNeXusWorkflow( | ||
| run_types=[SampleRun, OpenBeamRun, DarkBackgroundRun], | ||
| # Abusing the monitor_types to load proton charge and exposure time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'll need functionality, or just extend the workflow by hand?
|
Needs scipp/essreduce#278 |
This adds a workflow for normalizing images recorded by the Orca detector at TBL.
Sample images were made using a TBL file as a skeleton, and adding the Ymir lego images.
A fake proton charge log was added to the files.
This is used to normalize the images.
The latter part of the workflow should be common to other detectors and instruments (Odin).