Apply mask instead of changing values. #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Apr 9, 2025
src/ess/imaging/normalize.py
Outdated
| samples.data < sample_threshold, sample_threshold, samples.data | ||
| ) | ||
| samples.masks['counts'] = samples.data < sample_threshold | ||
| return SampleImageStacks(samples) |
Member
There was a problem hiding this comment.
How about just using something like
return SampleImageStacks(samples.assign_masks(counts=samples.data < sample_threshold))?
This would remove the need for the manual copy above.
nvaytet
approved these changes
Apr 10, 2025
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
We will probably have to update some workflows/notebooks that were using this function.
Not where the function is used, but where the masked objects are used.