Add utilities to compute image sharpness #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Aug 1, 2025
src/ess/imaging/tools/analysis.py
Outdated
|
|
||
|
|
||
| def resample( | ||
| image: sc.Variable | sc.DataArray, sizes: dict[str, int], method: str = 'sum' |
Member
There was a problem hiding this comment.
How about directly passing a callable object as a method argument?
YooSunYoung
approved these changes
Aug 1, 2025
Member
YooSunYoung
left a comment
YooSunYoung
left a comment
There was a problem hiding this comment.
I only had a minor comment.
src/ess/imaging/tools/analysis.py
Outdated
Comment on lines
82
to
84
| # if isinstance(image, sc.DataArray): | ||
| # image = image.data | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| # if isinstance(image, sc.DataArray): | |
| # image = image.data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds utilities to compute image sharpness which is used to find the focus point of an imaging detector.
A recording will typically have one image for each camera stage position.
We compute the sharpness of each one of these images, and find the sharpest one which is deemed to be the focus point of the camera.
This is not currently integrated into a full
GenericNeXusWorkflowbecause it is still unclear how the position of the camera will be recorded in the nexus file. Right now, it is recorded in a separateNXlog(camera_stage/position_setpoint), instead of being recorded as a time-dependent translation of the imaging detector.We don't know if this will still be the case in production.
The notebook produces this plot which shows how the focus point is found
