fix: meaning of start and stop in bin-edge widget with log scale#909
Merged
Conversation
Member
|
Got confused due to the lack of description, and because my brain read your issue title and said "Logscale" -> it is about plotting. But this is not about logscale, right? It is about how define define/configure edges to use in a workflow. Can you please clarify issue and PR titles and add a description in the PR itself? We are using those to create user-facing docs about changes. |
jokasimr
changed the title
start and stop in bin-edge widget
jokasimr
changed the title
start and stop in bin-edge widgetstart and stop in bin-edge widget with log scale
Contributor
Author
There is a description in the issue?
I've added the description to the PR and clarified the title. |
SimonHeybrock
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
Bug in the edge-widget in the workflow configuration page:
When the scale was set to scale.LOG the
startandstopentries in the selector representedlog10(...)of the start and stop of the desired range.With this fix the
startandstopentries in the widget represent the start and stop value of the range, which is the behavior users would expect.