Validity check when appending histogram on top of metadata #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
reviewed
Feb 27, 2025
Contributor
jokasimr
left a comment
jokasimr
left a comment
There was a problem hiding this comment.
Why do we need to check that the metadata matches? Is it plausible that they don't match?
YooSunYoung
force-pushed
the
validity-check
branch
from
71ccdc0 to
462d1ef
Compare
Member
Author
Yes, you could in principle use any files to append the histogram if detector name matches. |
jokasimr
approved these changes
Feb 27, 2025
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
Member
|
Related: #115 (comment) |
YooSunYoung
added a commit
that referenced
this pull request
Mar 27, 2025
* Lauetof export interface. * Raw data metadata as dataclass * Allow arbitrary metadata and export time of flight from the coordinate. * Specify unit Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com> * Add docstring to export methods. * Add missing attributes. * Remove comments * Write unit only when applicable. * Update comment. * Validity check when appending histogram on top of metadata (#116) * Separate metatadata from event data for easy export. * Add raw data metadata retrieval part. * Lauetof export interface. * Raw data metadata as dataclass * Allow arbitrary metadata and export time of flight from the coordinate. * Separate metatadata from event data for easy export. * Add raw data metadata retrieval part. * Satety check in the export function. * Add warning filter. * Apply automatic formatting * Apply automatic formatting * Fix typo * Move functions to more proper module. * Lauetof export interface. * Raw data metadata as dataclass * Allow arbitrary metadata and export time of flight from the coordinate. * Specify unit Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com> * Add docstring to export methods. * Add missing attributes. * Remove comments * Fix typo. * Apply automatic formatting --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com> * Wrap detector processing step. * Lower pin of essreduce to use accumulators. * Specify dtype of string. [skip ci] * Use essreduce accumulator. * Export NXsource. * Fix type hint * Apply automatic formatting * Data reduction wrapper interface (#122) * Executable module. * Save crystal rotation. * Fix crystal rotation. * Remove all zero lines, not just the first one (#123) * remove all zero lines, not just the first one * Apply automatic formatting * Update src/ess/nmx/mcstas/load.py * Apply automatic formatting --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Sunyoung Yoo <luysunyoung9@gmail.com> * Apply suggestions from code review Co-authored-by: Mridul Seth <mail@mriduls.com> * Apply automatic formatting * Add bitshuffle support, compress binned datasets using bitshuffle/LZ4 (#125) * add bitshuffle support, compress binned datasets using bitshuffle/LZ4 * Apply automatic formatting * Add docstring and option. --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: YooSunyoung <luysunyoung9@gmail.com> * Update default space group in mtz io module (#126) * Executable module. * Save crystal rotation. * Fix crystal rotation. * Remove all zero lines, not just the first one (#123) * remove all zero lines, not just the first one * Apply automatic formatting * Update src/ess/nmx/mcstas/load.py * Apply automatic formatting --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Sunyoung Yoo <luysunyoung9@gmail.com> * Apply suggestions from code review Co-authored-by: Mridul Seth <mail@mriduls.com> * Apply automatic formatting * Add bitshuffle support, compress binned datasets using bitshuffle/LZ4 (#125) * add bitshuffle support, compress binned datasets using bitshuffle/LZ4 * Apply automatic formatting * Add docstring and option. --------- Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: YooSunyoung <luysunyoung9@gmail.com> * Update mtz_io.py make default space group P1 (lowest symmetry space group) * Update default space group in tests. --------- Co-authored-by: YooSunyoung <luysunyoung9@gmail.com> Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Mridul Seth <mail@mriduls.com> --------- Co-authored-by: Aaron Finke <45569605+aaronfinke@users.noreply.github.com> Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Mridul Seth <mail@mriduls.com> --------- Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Aaron Finke <45569605+aaronfinke@users.noreply.github.com> Co-authored-by: Aaron Finke <aaron.finke@ess.eu> Co-authored-by: Mridul Seth <mail@mriduls.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it's only checking very few things but later we can add more metadata in the exported group and check them later.