Retrieve crystal rotation from nexus file.#155
Merged
YooSunYoung merged 1 commit intomainfrom Nov 10, 2025
Merged
Conversation
Member
|
It would be great if we could get a solution that also works for other instruments. For BIFROST, it is stored in an NXparameter group in AFAIK, there is not decision on how ECDC will store it. But it should be something similar. |
jokasimr
reviewed
Nov 10, 2025
| RuntimeWarning, | ||
| stacklevel=2, | ||
| ) | ||
| return sc.vector([0, 0, 0], unit='deg') |
Contributor
There was a problem hiding this comment.
Do we need this for backwards compatibility?
Member
Author
There was a problem hiding this comment.
Sort of...? It's for the next step of the reduction.
As far as I understood, DIALS expect this field in the file.
jokasimr
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to export crystal_rotation (sample orientation) to the output file for next step of reduction.
We haven't settled about how exactly to store this information in the real nexus file.
This is a improvised temporary solution for (mcstas to nexus) translated files.