Update configurations and reduction interface function signature.#167
Merged
YooSunYoung merged 5 commits intoisolate-mcstasfrom Dec 5, 2025
Merged
Update configurations and reduction interface function signature.#167YooSunYoung merged 5 commits intoisolate-mcstasfrom
YooSunYoung merged 5 commits intoisolate-mcstasfrom
Conversation
Member
YooSunYoung
commented
Dec 4, 2025
YooSunYoung
commented
- Add tof simulation seed to the configuration.
- Use configuration object instead of passing individual argument.
YooSunYoung
commented
Dec 4, 2025
Comment on lines
193
to
198
| def reduction( | ||
| *, | ||
| input_file: list[pathlib.Path] | pathlib.Path, | ||
| output_file: pathlib.Path, | ||
| chunk_size: int = 1_000, | ||
| detector_ids: list[int | str], | ||
| compression: Compression = Compression.BITSHUFFLE_LZ4, | ||
| config: ReductionConfig, | ||
| logger: logging.Logger | None = None, | ||
| min_toa: sc.Variable | int = 0, | ||
| max_toa: sc.Variable | int = int((1 / 14) * 1_000), # Default for ESS NMX | ||
| toa_bin_edges: sc.Variable | int = 250, | ||
| fast_axis: Literal['x', 'y'] | None = None, # 'x', 'y', or None to auto-detect | ||
| display: Callable | None = None, # For Jupyter notebook display | ||
| display: Callable | None = None, | ||
| ) -> sc.DataGroup: |
Member
Author
There was a problem hiding this comment.
This is the only important part.
The rest of the function will be updated in the later PR.
YooSunYoung
commented
Dec 4, 2025
Member
Author
There was a problem hiding this comment.
This file will be completely re-written in the later PR so no need to take a close look...
IO helper in the reduction function.
Retrieve input/output file paths in the reduction function.
SimonHeybrock
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.