Handle different TimeOfFlightLookUpTable type.#180
Merged
YooSunYoung merged 2 commits intomainfrom Dec 17, 2025
Merged
Conversation
nvaytet
reviewed
Dec 17, 2025
| tof_lut.array *= 2 | ||
| if isinstance(tof_lut, sc.DataArray): | ||
| tof_lut *= 2 | ||
| elif isinstance(tof_lut, sc.DataGroup): |
Member
There was a problem hiding this comment.
I don't think the table was ever a DataGroup.
I first tried that out, but it was never merged into main, it got replaced by the dataclass in the same PR and that got merged...
Member
Author
There was a problem hiding this comment.
I see...! Fixed now.
YooSunYoung
commented
Dec 17, 2025
nvaytet
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the recent releases, we changed the type of
TimeOfFlightLookUpTabletype, fromDataArraytoDataGroupand then todataclass.It didn't affect the package itself but just one pytest so instead of raising the lower bound, I just fixed the unittest.
The lower bound test was triggered here: https://github.com/scipp/essnmx/actions/runs/20297448245/job/58294470348