Allow explicit selection of compression option and add benchmark result in the documentation page.#189
Merged
YooSunYoung merged 5 commits intomainfrom Jan 22, 2026
Merged
Allow explicit selection of compression option and add benchmark result in the documentation page.#189YooSunYoung merged 5 commits intomainfrom
YooSunYoung merged 5 commits intomainfrom
Conversation
Member
SimonHeybrock
left a comment
SimonHeybrock
left a comment
There was a problem hiding this comment.
No tests, or just no test changes necessary because there are existing ones?
Member
Author
There are some tests related to the compression options but I'll add more tests to see if it actually compress the dataset. |
YooSunYoung
commented
Jan 22, 2026
Comment on lines
+492
to
+496
| @pytest.mark.skipif( | ||
| BITSHUFFLE_AVAILABLE, | ||
| reason="Bitshuffle is available in this environment so it won't fall back.", | ||
| ) | ||
| def test_reduction_compression_bitshuffle_fall_back_to_gzip( |
Member
Author
There was a problem hiding this comment.
This test will be skipped on our CI but I tested on my local machine (mac) and it worked.
Member
Author
|
@SimonHeybrock I added some tests. will you have a look again? |
Comment on lines
+432
to
+444
| try: | ||
| # Just checking availability | ||
| import bitshuffle.h5 # noqa: F401 | ||
| except ImportError: | ||
| BITSHUFFLE_AVAILABLE = False | ||
| else: | ||
| BITSHUFFLE_AVAILABLE = True | ||
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| not BITSHUFFLE_AVAILABLE, | ||
| reason="Bitshuffle is not available in this environment.", | ||
| ) |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Yeah but we have another test that is skipped if it IS available.
It looks like importorskip skips the test only if the module is not avaiable.
SimonHeybrock
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scipp/ess#199
The notebook for the benchmark was shared in the nmx slack channel... I didn't think it was necessary to store it somewhere...