docs: update the parameters in the comparison to eos #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Apr 29, 2025
Member
nvaytet
left a comment
nvaytet
left a comment
There was a problem hiding this comment.
Sorry I had started my review 2 weeks ago but never clicked "Submit Review"...
| "workflow[ChopperPhase[SampleRun]] = sc.scalar(-7.5, unit='deg')\n", | ||
| "\n", | ||
| "workflow[WavelengthBins] = sc.geomspace('wavelength', 2.8, 12.5, 301, unit='angstrom')\n", | ||
| "workflow[WavelengthBins] = sc.geomspace('wavelength', 2.8, 12.5, 2001, unit='angstrom')\n", |
Member
There was a problem hiding this comment.
Did this make any noticeable difference to RAM usage or test runtimes?
Contributor
Author
There was a problem hiding this comment.
Not noticeable, but it does increase the runtime of computing the reference slightly.
On my workstation the difference is from previously 1.76s to now 1.9s.
nvaytet
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the number of bins in wavelength to a value was found to be more suitable.
The suitable number of bins was determined by reducing data from a known sample, with different number of wavelength bin-edges, and comparing the results.