Skip to content

docs: update the parameters in the comparison to eos #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

docs: update the parameters in the comparison to eos #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5053fd
docs: update the parameters in the comparison to eos
jokasimr Apr 15, 2025
2a9ff3d
Merge branch 'main' into update-psi-comparison
jokasimr Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/user-guide/amor/compare-to-eos.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,13 @@
"workflow[SampleSize[ReferenceRun]] = sc.scalar(10.0, unit='mm')\n",
"workflow[ChopperPhase[SampleRun]] = sc.scalar(-7.5, unit='deg')\n",
"\n",
"workflow[WavelengthBins] = sc.geomspace('wavelength', 2.8, 12.5, 301, unit='angstrom')\n",
"workflow[WavelengthBins] = sc.geomspace('wavelength', 2.8, 12.5, 2001, unit='angstrom')\n",
Copy link
Member

@nvaytet nvaytet Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this make any noticeable difference to RAM usage or test runtimes?

Copy link
Contributor Author

@jokasimr jokasimr Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not noticeable, but it does increase the runtime of computing the reference slightly.
On my workstation the difference is from previously 1.76s to now 1.9s.

"workflow[QBins] = sc.geomspace(\n",
" dim='Q', start=0.00505, stop=2.93164766e-01, num=391, unit='1/angstrom'\n",
")\n",
"workflow[YIndexLimits] = sc.scalar(11), sc.scalar(41)\n",
"workflow[ZIndexLimits] = sc.scalar(80), sc.scalar(370)\n",
"workflow[BeamDivergenceLimits] = sc.scalar(-0.75, unit='deg'), sc.scalar(0.75, unit='deg')\n",
"\n",
"# Chopper phase value in the file is wrong, so we set it manually\n",
"workflow[ChopperPhase[ReferenceRun]] = sc.scalar(-7.5, unit='deg')\n",
Expand Down
Loading