Skip to content

Broken workflows when using with_sample_runs and with_background_runs #211

@SimonHeybrock

Description

@SimonHeybrock

I think I introduced a bug in #163. After that change, the nodes we should "reduce" at in the graph are different. I did not look into all details yet, but very roughly:

  • Sum CleanMonitor.
  • We should not sum or concat CleanSummedQ[Denominator], I think? Should this be the mean now? In general this should be the same in all runs, so we might also check for that, or not even to any map/merge in this branch?
  • Is this still consistent overall? Is it ok to split the CleanSummedQ[Denominator] from the monitor sums, which affects the transmission fraction? It makes sense when a separate transmission run is used, but does the logic carry over to the case of using the transmission monitors from the sample runs? What about cases where the solid angle term is different (rear detector moved), shouldn't we add the monitor contribution before reducing the denominator term?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions