Fix run mapping functionality #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Jun 4, 2025
| for part in (Numerator, Denominator): | ||
| pipeline[CleanSummedQ[key, part]] = ( | ||
| pipeline[CleanSummedQ[key, part]] | ||
| pipeline[WavelengthScaledQ[key, part]] = ( |
Member
There was a problem hiding this comment.
I guess my only question is: did the results change at all after this modification?
Member
Author
There was a problem hiding this comment.
Before this fix it either did not work, or the monitor term from a single run was used for all, i..e, it should be different.
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
Support ISIS histogram files
nvaytet
approved these changes
Jun 10, 2025
| Filename=str(filename), LoadMonitors=True, StoreInADS=False | ||
| ) | ||
| # Loading many small files with Mantid is, for some reason, very slow when using | ||
| # the default number of threads in the Dask threaded scheduler (1 thread worked |
Member
There was a problem hiding this comment.
Can it be because multi-threading is also used internally by Mantid when it is loading the data?
Member
Author
There was a problem hiding this comment.
I think I checked when I first wrote this (note this code and comment was simply moved in this PR). I don't think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211.
Note
This is not addressed in this PR. Is this something that needs fixing?