test: update reference data #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test fails because in CI we still have |
pyproject.toml
Outdated
| "pandas", | ||
| "plopp", | ||
| "pythreejs", | ||
| "scipy>=1.15.0", |
Member
There was a problem hiding this comment.
Hmm, should this pin be only for the tests, maybe? The package works perfectly with older Scipy after all.
The latest scipy release updated the values of various constants, among them the neutron mass. The changes made the tests fail.
SimonHeybrock
approved these changes
Jan 20, 2025
Contributor
Author
|
I don't know why the docs build fails. It seems it has something to do with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
The unpinned tests failed because of changes to
scipy.constants(specifically the Neutron mass).I've just replaced the old reference files with what is returned by the workflow.
Do we we want to relax the tolerance on the assertion to avoid getting similar issues in the future?
I imagine a relative tolerance of
1e-5(currently1e-7) might be good enough?