Conversation
nvaytet
approved these changes
Jan 5, 2026
nvaytet
requested changes
Jan 5, 2026
| wf[TofLookupTableFilename] = loki.data.loki_tof_lookup_table_no_choppers() | ||
|
|
||
| result = wf.compute(BackgroundSubtractedIofQ) | ||
| assert result.dims == ('Q',) |
Member
There was a problem hiding this comment.
Actually I think you need to update the docs also...
Member
Author
There was a problem hiding this comment.
I thought I did. Grepping for TimeOfFlight doesn't find anything.
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
(base) nvaytet@asus:~/code/sans/source/docs$ gr TimeOfFlight
user-guide/loki/loki-make-tof-lookup-table.ipynb: "table = wf.compute(time_of_flight.TimeOfFlightLookupTable)\n",
user-guide/loki/loki-reduction-ess.ipynb: "wf[TimeOfFlightLookupTableFilename] = loki.data.loki_tof_lookup_table_no_choppers()\n",
(base) nvaytet@asus:~/code/sans/source/docs$
Member
Author
There was a problem hiding this comment.
That links to main. Here is the updated file on this branch: https://github.com/scipp/esssans/blob/187f77ec909ae7f79afbbc0581884c1387501f3d/docs/user-guide/loki/loki-reduction-ess.ipynb
Member
There was a problem hiding this comment.
Sorry I'm not looking at this properly. For some reason I was expecting the diff for the docs to be after the tests, while I actually read through it at the top, and then forgot about it... 😞
nvaytet
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the nightly test.