SXD: Add providers for computing Q histograms#70
Merged
Conversation
Comment on lines
+85
to
+86
| ) -> QHistogram[RunType]: | ||
| """Integrate the data over |Q| and histogram in the sample rotation.""" |
Member
There was a problem hiding this comment.
This seems to be something quite specific, does it deserve a better name? QHistogram does not tell me much about what it is.
Comment on lines
+74
to
+76
| ) -> Q2dHistogram[RunType]: | ||
| """Histogram the data in Q_parallel and Q_perpendicular""" | ||
| return Q2dHistogram[RunType]( |
Member
There was a problem hiding this comment.
Not sure about the naming, is there a better option? If not, feel free to ignore this comment.
Member
Author
There was a problem hiding this comment.
I changed the names. What do you think?
Note that the data does not yet represent intensities. But that is what it will ultimately be once we implement normalisation.
Comment on lines
+30
to
+33
| class Q2dHistogram(sciline.Scope[RunType, sc.DataArray], sc.DataArray): ... | ||
|
|
||
|
|
||
| class QHistogram(sciline.Scope[RunType, sc.DataArray], sc.DataArray): ... |
| CountsWithQMapCoords, | ||
| Q2dHistogram, | ||
| QHistogram, | ||
| IntensityQparQPerp, |
Member
There was a problem hiding this comment.
Inconsistent camel-casing.
92375ee to
e6c1347
Compare
SimonHeybrock
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the SXD workflow ready for live processing. Simply request the new
Q2dHistogramandQHistogram. (See below.)Once we can select ROI's in the dashboard, we should see if we can adapt this workflow for it.
You can use the workflow by adapting the bragg peak monitor docs notebook: