-
Notifications
You must be signed in to change notification settings - Fork 5
fix: replace label for multiple scatter #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Also works correctly for |
|
My guess is that it was fixed in https://github.com/scipp/plopp/pull/490/files#diff-27d11e8f8609ce7cd65b7314517bd96d9f9576419e191f04b9fee648be5fd3c6 (it works in version |
|
Aha I see. Should've checked before "fixing" it 🙄 |
nvaytet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we remove the changes but keep the tests 😉
Co-authored-by: Neil Vaytet <39047984+nvaytet@users.noreply.github.com>
| b.coords['x'] += sc.scalar(50.0, unit='m') | ||
|
|
||
| fig = pp.scatter({'a': a, 'b': b}) | ||
| assert fig.canvas.ylabel == '[K]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the label [K]? Shouldn't it be y [m]?
I think K is the units of the data, not the xy coords?
|
I don't know why the CI is not running... 🤔 |

Fixes #451