Do not put things into :root to avoid bad performance of _repr_html_#1847
Merged
SimonHeybrock merged 5 commits intomainfrom Apr 21, 2021
Merged
Do not put things into :root to avoid bad performance of _repr_html_#1847SimonHeybrock merged 5 commits intomainfrom
SimonHeybrock merged 5 commits intomainfrom
Conversation
SimonHeybrock
changed the title
Member
|
I moved the custom property definitions into |
2 tasks
SimonHeybrock
commented
Apr 21, 2021
| for key, val in config['colors'].items()}) | ||
|
|
||
|
|
||
| def _preprocess_style(template: str) -> str: |
SimonHeybrock
commented
Apr 21, 2021
Member
Author
SimonHeybrock
left a comment
SimonHeybrock
left a comment
There was a problem hiding this comment.
Tried after the latest changes, still fixes the problem. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1794 creating HTML output had become laggy, and it got worse the more cells a notebook contained. Lag was in the
0.5 sto> 1 srange, once a notebooks contained dozens of cells or more.The root cause seems to be placement of CSS custom properties (colors in this case) in
:root.