Convert angle dtype to float in polar_to_svg_coords#676
Merged
YooSunYoung merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
nvaytet
reviewed
Mar 3, 2026
| def polar_to_svg_coords(*, r: sc.Variable, a: sc.Variable) -> tuple[float, float]: | ||
| x = to_svg_coord(r * -sc.sin(a)) | ||
| x = to_svg_coord(r * -sc.sin(a.to(dtype=float))) | ||
| y = image_size - to_svg_coord(r * sc.cos(a)) |
Member
There was a problem hiding this comment.
The same should be done for cos here?
Member
Author
There was a problem hiding this comment.
Fixed it...! Thanks...!
We had this error while working on Trex choppers. I think it's safe to convert this to float if it's integer for visualization. Or should we do this in the constructor itself...?
nvaytet
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had this error while working on Trex choppers.
I think it's safe to convert this to float if it's integer for visualization.
Or should we do this in the constructor itself...?