Merged
Conversation
Member
Author
|
@damskii9992 do you have time to review this? |
damskii9992
approved these changes
Jan 22, 2026
Collaborator
damskii9992
left a comment
damskii9992
left a comment
There was a problem hiding this comment.
I did not really go through all the logic, but I read the new schema on how it will work and I like it :) So assuming it works, I'd approve it. If you want me to do an actual code review I can also do that, but it'll take a while as I am off on Friday and Monday :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it saves
sc.DataGroupincluding the highlevel metadata.