Conversation
nvaytet
changed the title
YooSunYoung
reviewed
Dec 9, 2025
Comment on lines
+78
to
+90
| dream_high_resolution = copy.deepcopy(dream_high_flux) | ||
| dream_high_resolution["PSC1"]["frequency"]["value"] = 15 * 14.0 | ||
| dream_high_resolution["PSC1"]["phase"]["value"] = 25 - 180 | ||
| dream_high_resolution["PSC2"]["frequency"]["value"] = 14 * 14.0 | ||
| dream_high_resolution["PSC2"]["phase"]["value"] = 100.5 | ||
| dream_high_resolution["OC"]["frequency"]["value"] = 14.0 | ||
| dream_high_resolution["OC"]["phase"]["value"] = 297.0 - 180.0 - 90.0 | ||
| dream_high_resolution["BC"]["frequency"]["value"] = 112.0 | ||
| dream_high_resolution["BC"]["phase"]["value"] = 200.0 - 180.0 | ||
| dream_high_resolution["T0"]["frequency"]["value"] = 28.0 | ||
| dream_high_resolution["T0"]["phase"]["value"] = 270.0 - 180.0 | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
What's the reference of these numbers...? Are they from the mcstas model repos?
Member
Author
There was a problem hiding this comment.
From a confluence page Celine has (plus some offsets due to how mcstas works), but I don't feel like linking confluence pages in the code as they are not accessible from the outside...
But you are right that it's annoying to have magic numbers in here.
Member
There was a problem hiding this comment.
I agree, I asked so that I can go through it myself and review it but I'll just trust you : D...
Member
Author
There was a problem hiding this comment.
Here is the link: https://confluence.ess.eu/spaces/~celinedurniak/pages/409097236/NeXus+baseline+file+for+DREAM
(only accessible on ESS network/VPN)
YooSunYoung
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.