Conversation
| "\n", | ||
| "instruments = {\n", | ||
| " \"Odin\": {\n", | ||
| " \"facility\": \"ess-odin\",\n", |
There was a problem hiding this comment.
| " \"facility\": \"ess-odin\",\n", | |
| " \"facility\": \"ess\",\n", |
?
There was a problem hiding this comment.
No, odin has a specific source that was measured in mcstas at the entrance of the beamport which is called ess-odin.
There was a problem hiding this comment.
Ok, I would have expected that to be separate from 'facility'. But if you have no need for encoding a facility itself, then that should be fine.
There was a problem hiding this comment.
Maybe i'll just make a single source for everyone, will reduce notebook build time.
ess or ess-odin won't make a difference for this notebook.
There was a problem hiding this comment.
But it is important to show that there is a dedicated source for odin. And people should probably use that one, right?
There was a problem hiding this comment.
Would it help if I documented the facility argument better in the docstring, or make a docs page listing the available sources?
There was a problem hiding this comment.
Both would be useful. I think people are more likely to find the new docs page, so I'd focus on that.
There was a problem hiding this comment.
The old pages had a lot more content, e.g., examples of computing wavelength. Why did you remove those?
There was a problem hiding this comment.
Yes, but that info is also in the https://scipp.github.io/tof/wfm.html notebook, so it felt very redundant...
2 participants
No description provided.