Skip to content

Change the tof coordinate to actually be the time-of-flight#114

Merged
nvaytet merged 2 commits intomainfrom
correct-tof-coordinate
Jan 15, 2026
Merged

Change the tof coordinate to actually be the time-of-flight#114
nvaytet merged 2 commits intomainfrom
correct-tof-coordinate

Conversation

@nvaytet
Copy link
Copy Markdown
Member

@nvaytet nvaytet commented Jan 5, 2026

Change the tof coordinate to actually be the time-of-flight instead of the time-of-arrival.

@nvaytet nvaytet marked this pull request as ready for review January 6, 2026 12:53
@nvaytet nvaytet requested a review from jl-wynen January 15, 2026 11:02
Copy link
Copy Markdown
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use the 'tof' coord somewhere in our packages and would this change break those packages?

@nvaytet
Copy link
Copy Markdown
Member Author

nvaytet commented Jan 15, 2026

I don't think so. A grep in essreduce didn't come up with anything.
I ran essreduce tests and essdiffraction tests and they both passed.

@nvaytet nvaytet merged commit 5d219c1 into main Jan 15, 2026
4 checks passed
@nvaytet nvaytet deleted the correct-tof-coordinate branch January 15, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants