adding kf/ki factor to the cooridnates for InelasticSample class#138
Merged
Conversation
nvaytet
approved these changes
Apr 17, 2026
| wavelength=w_final, speed=wavelength_to_speed(w_final) | ||
| wavelength=w_final, | ||
| speed=wavelength_to_speed(w_final), | ||
| kf_over_ki=sc.sqrt(final_energy / incident_energy), |
Member
There was a problem hiding this comment.
We can add as much info as you like, so if adding other quantities would make things simpler down the line, feel free to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the elastic scattering process, the double differential cross section if proportional to kf/ki*S(Q,E). Right now, the InelasticSample keeps the information about the final energy/wavelength only and discard the information about the initial wavelength/energy. Once it happens, it is impossible to get the information back. I am proposing to add the ratio of kf/ki to the coordinates, which will help with the further calculation of the double differential cross section.