-
Notifications
You must be signed in to change notification settings - Fork 1
Minor UI fixes #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor UI fixes #74
Conversation
peppermint-juli
commented
Oct 14, 2025
- Fixed and unified typography and heading/body use across the app
- Moved re-run to job full detail based on feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR focuses on unifying typography across the UI and relocating the “Re-run job” action from the jobs list to the job detail view.
- Unifies global typography and heading/body text via CSS and Google Fonts.
- Moves the job re-run action into the full job detail page and removes it from the list grid.
- Updates GraphQL queries: trims GET_JOBS fields and augments JOB_DETAIL_VIEW with fields needed for re-run.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| components/ui/web/src/graphql/jobs.ts | Adjusts queried fields: removes unused fields from GET_JOBS; adds fields (scriptURI, volumes, etc.) to JOB_DETAIL_VIEW for rerun. |
| components/ui/web/pages/_app.tsx | Adds global typography styles, font preconnects, and Google Fonts; standardizes base element styles. |
| components/ui/web/components/content/jobs/list/jobsList.tsx | Removes job creation mutation and handler; simplifies data source for the list. |
| components/ui/web/components/content/jobs/list/jobDatagrid.tsx | Removes “Re-run” action column and related props/icons; keeps expand/collapse row details. |
| components/ui/web/components/content/jobs/detail/jobShortDetail.tsx | Replaces MUI Typography with semantic h/p tags; layout tweaks for details. |
| components/ui/web/components/content/jobs/detail/jobFullDetail.tsx | Adds rerun mutation and a “Re-run” button within job details; maintains files grid. |
| components/ui/web/components/content/compute/sessionManagement/sessionManagement.tsx | Swaps MUI Typography header for semantic h1. |
Comments suppressed due to low confidence (1)
components/ui/web/components/content/jobs/list/jobDatagrid.tsx:104
- The fragment returned from jobsList.map lacks a key, which will trigger React's 'Each child in a list should have a unique key' warning. Wrap the block in <React.Fragment key={job.id}> (or move the key from TableRow to the fragment) and remove the redundant key on TableRow.
<TableRow key={job.id}>
<TableCell>
<IconButton
aria-label="expand row"
size="small"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
components/ui/web/components/content/jobs/detail/jobFullDetail.tsx
Outdated
Show resolved
Hide resolved
components/ui/web/components/content/jobs/detail/jobFullDetail.tsx
Outdated
Show resolved
Hide resolved
components/ui/web/components/content/jobs/detail/jobFullDetail.tsx
Outdated
Show resolved
Hide resolved
amitschang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem fine to me, but maybe should fix that duplicate issue prior to merge
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>