Skip to content

Conversation

@peppermint-juli
Copy link
Contributor

  • Fixed and unified typography and heading/body use across the app
  • Moved re-run to job full detail based on feedback

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on unifying typography across the UI and relocating the “Re-run job” action from the jobs list to the job detail view.

  • Unifies global typography and heading/body text via CSS and Google Fonts.
  • Moves the job re-run action into the full job detail page and removes it from the list grid.
  • Updates GraphQL queries: trims GET_JOBS fields and augments JOB_DETAIL_VIEW with fields needed for re-run.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
components/ui/web/src/graphql/jobs.ts Adjusts queried fields: removes unused fields from GET_JOBS; adds fields (scriptURI, volumes, etc.) to JOB_DETAIL_VIEW for rerun.
components/ui/web/pages/_app.tsx Adds global typography styles, font preconnects, and Google Fonts; standardizes base element styles.
components/ui/web/components/content/jobs/list/jobsList.tsx Removes job creation mutation and handler; simplifies data source for the list.
components/ui/web/components/content/jobs/list/jobDatagrid.tsx Removes “Re-run” action column and related props/icons; keeps expand/collapse row details.
components/ui/web/components/content/jobs/detail/jobShortDetail.tsx Replaces MUI Typography with semantic h/p tags; layout tweaks for details.
components/ui/web/components/content/jobs/detail/jobFullDetail.tsx Adds rerun mutation and a “Re-run” button within job details; maintains files grid.
components/ui/web/components/content/compute/sessionManagement/sessionManagement.tsx Swaps MUI Typography header for semantic h1.
Comments suppressed due to low confidence (1)

components/ui/web/components/content/jobs/list/jobDatagrid.tsx:104

  • The fragment returned from jobsList.map lacks a key, which will trigger React's 'Each child in a list should have a unique key' warning. Wrap the block in <React.Fragment key={job.id}> (or move the key from TableRow to the fragment) and remove the redundant key on TableRow.
                <TableRow key={job.id}>
                  <TableCell>
                    <IconButton
                      aria-label="expand row"
                      size="small"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@amitschang amitschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem fine to me, but maybe should fix that duplicate issue prior to merge

peppermint-juli and others added 4 commits October 14, 2025 16:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@peppermint-juli peppermint-juli merged commit 9e34e10 into main Oct 14, 2025
2 of 3 checks passed
@peppermint-juli peppermint-juli deleted the WEB/UI-changes branch October 14, 2025 21:34
@peppermint-juli peppermint-juli restored the WEB/UI-changes branch October 17, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants