fix(prompt): remove hardcoded 5-minute reference from cron section#201
Merged
Conversation
The cron system prompt said "You have a 5-minute time limit" which duplicates the EXECUTION_TIMEOUT_MS constant in cron-service.ts. If the timeout is changed, the prompt would be out of sync. Replace with "strict time limit" to avoid the coupling.
- Check MIN_INTERVAL_MS (60 min) before ABSOLUTE_MIN_GAP_MS (10 min) so
users see the real constraint upfront instead of a confusing two-step
error ("10 min" then "60 min")
- Burst-firing error now also mentions the average interval limit
- Add minimum interval note to manage_schedule tool description so the
model knows the limit upfront and doesn't trial-and-error
- Remove "every minute" from common patterns (not achievable)
LikiosSedo
force-pushed
the
fix/cron-hardcoded-timeout
branch
from
5c18165 to
20ac771
Compare
jacoblee-io
approved these changes
Apr 1, 2026
Collaborator
jacoblee-io
left a comment
jacoblee-io
left a comment
There was a problem hiding this comment.
LGTM.
- Prompt decoupled from hardcoded timeout value
- Validation order fix is correct:
MIN_INTERVAL_MS(60 min) >ABSOLUTE_MIN_GAP_MS(10 min), so checking the stricter limit first avoids confusing two-step errors - Burst error message now includes average interval limit for context
- Tool description derives minimum interval from
CRON_LIMITS— stays in sync automatically - "Every minute" pattern removed from examples — good, it was never achievable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The cron system prompt contains a hardcoded "You have a 5-minute time limit" that duplicates
EXECUTION_TIMEOUT_MSincron-service.ts. If the timeout constant is changed, the prompt becomes misleading.Solution
Replace "5-minute time limit" with "strict time limit" — the model gets the behavioral hint without coupling to a specific value.
This was intended for PR #198 but the second commit didn't make it into the merge.