Skip to content

Fix build failures #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbockelm merged 3 commits into from
Jun 20, 2019
Merged

Fix build failures #11

bbockelm merged 3 commits into from
Jun 20, 2019

Conversation

@bbockelm
Copy link
Contributor

@bbockelm bbockelm commented Jun 20, 2019

Fixes:

  • Warnings due to an unused static function.
  • Passing polymorphic exceptions by value.
  • OpenSSL 1.1 API changes.

@bbockelm
Copy link
Contributor Author

bbockelm commented Jun 20, 2019

Fixes #10

djw8605
djw8605 approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the builds work, this looks good.

@bbockelm
Copy link
Contributor Author

bbockelm commented Jun 20, 2019

In #10 we confirmed this patch works on all Debian platforms. Merging.

@bbockelm bbockelm merged commit d6ac21b into scitokens:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djw8605 djw8605 djw8605 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbockelm @djw8605