Add support for IAM #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents of the public key JSON are base64 encoded using the standard JWT rules. This fixes the fact we did not internal pad the values inside the public keys, causing base64 decoding failures for specific issuers (such as our test IAM endpoint). This prevented us from verifying any SciToken from endpoints using the affected public keys.
It's not mandatory to have an `alg` claim in the JWKS; we can derive the information we need from the `kty` (key type) claim. The java library used by IAM does not advertise `alg`. There's potentially more work to do here if we want to support additional RSA signing algorithms.
djw8605
approved these changes
Sep 13, 2019
Contributor
djw8605
left a comment
djw8605
left a comment
There was a problem hiding this comment.
I had a similar issue with the incorrectly padded base64. I interpreted it as incorrect base64, and didn't make a change to the scitokens code. Though, I'm fine with this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some bugfixes required for supporting IAM; there's nothing specific to that particular issuer, but rather some technical issues with
scitokens-cpp:base64pieces of the public keys.algclaim in the public key; instead, try to bootstrap this from the (required)ktyifalgisn't available.