Add cmake option SCITOKENS_WITH_ASAN which enables memory checking #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the address sanitizer. Also enable this in CI, so that tests fail if they hit a memory leak or other memory problem.
downloaded from https://github.com/Thalhammer/jwt-cpp/releases/tag/v0.7.1 jwt-cpp 0.7.1 removes the "get_payload_claims" method, and replaces it with "get_payload_json", which returns a json document, not a map. More importantly for us, jwt-cpp 0.7.1 also fixes warnings about deprecated wstring uses, so we can be warning-clean on g++ 15.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Not mission critical, but keeps valgrind/asan output clean
Contributor
|
I messed up git, so moving this over to #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a couple of memory leaks in scitokens-cpp by compiling with the address sanitizer on, and running the unit tests. Let's do this in CI, so that we catch any new problems in the future.