Skip to content

Fix memory leaks in the unit tests #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djw8605 merged 1 commit into from
Apr 28, 2025
Merged

Fix memory leaks in the unit tests #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion test/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,11 @@ TEST_F(SerializeTest, VerifyTest) {
ASSERT_TRUE(rv == 0) << err_msg;
std::unique_ptr<char, decltype(&free)> value_ptr(value, free);
EXPECT_STREQ(value, "https://demo.scitokens.org/gtest");

value_ptr.reset();

rv = scitoken_get_claim_string(m_read_token.get(), "doesnotexist", &value,
&err_msg);
free(err_msg);
EXPECT_FALSE(rv == 0);
}

Expand All @@ -154,6 +155,7 @@ TEST_F(SerializeTest, TestStringList) {
EXPECT_STREQ(value[1], "group1");

EXPECT_TRUE(value[2] == nullptr);
scitoken_free_string_list(value);
}

TEST_F(SerializeTest, VerifyWLCGTest) {
Expand Down Expand Up @@ -181,6 +183,8 @@ TEST_F(SerializeTest, VerifyWLCGTest) {

value_ptr.reset();
rv = scitoken_get_claim_string(m_read_token.get(), "ver", &value, &err_msg);
free(err_msg);
err_msg = nullptr;
EXPECT_FALSE(rv == 0);

// Accepts only a WLCG token
Expand All @@ -195,6 +199,7 @@ TEST_F(SerializeTest, VerifyWLCGTest) {
SciTokenProfile::SCITOKENS_1_0);
rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand Down Expand Up @@ -223,6 +228,7 @@ TEST_F(SerializeTest, FailVerifyToken) {

// Should fail; we signed it with the wrong public key.
rv = scitoken_deserialize_v2(value, m_read_token.get(), nullptr, &err_msg);
free(err_msg);
EXPECT_FALSE(rv == 0);
}

Expand Down Expand Up @@ -254,6 +260,7 @@ TEST_F(SerializeTest, VerifyATJWTTest) {
SciTokenProfile::SCITOKENS_2_0);
rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand All @@ -278,6 +285,7 @@ TEST_F(SerializeTest, FailVerifyATJWTTest) {
SciTokenProfile::AT_JWT);
rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand Down Expand Up @@ -315,12 +323,15 @@ TEST_F(SerializeTest, EnforcerTest) {
rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
ASSERT_TRUE(rv == 0) << err_msg;
free(err_msg);

rv = enforcer_test(enforcer, m_read_token.get(), &acl, &err_msg);
ASSERT_STREQ(
err_msg,
"token verification failed: 'scope' claim verification failed.");
ASSERT_TRUE(rv == -1) << err_msg;
free(err_msg);
enforcer_destroy(enforcer);
}

TEST_F(SerializeTest, EnforcerScopeTest) {
Expand All @@ -347,6 +358,7 @@ TEST_F(SerializeTest, EnforcerScopeTest) {

rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(token_value);
ASSERT_TRUE(rv == 0) << err_msg;

Acl *acls;
Expand All @@ -366,6 +378,8 @@ TEST_F(SerializeTest, EnforcerScopeTest) {
ASSERT_STREQ(resource, "/");
}
}
enforcer_acl_free(acls);
enforcer_destroy(enforcer);
ASSERT_TRUE(found_read);
ASSERT_TRUE(found_write);
}
Expand Down Expand Up @@ -395,6 +409,7 @@ TEST_F(SerializeTest, DeserializeAsyncTest) {
rv = scitoken_deserialize_continue(&scitoken, &status, &err_msg);
ASSERT_TRUE(rv == 0) << err_msg;
}
scitoken_destroy(scitoken);
}

TEST_F(SerializeTest, FailDeserializeAsyncTest) {
Expand Down Expand Up @@ -430,11 +445,15 @@ TEST_F(SerializeTest, FailDeserializeAsyncTest) {
rv = scitoken_deserialize_start(value, &scitoken, nullptr, &status,
&err_msg);
EXPECT_FALSE(rv == 0) << err_msg;
free(err_msg);
err_msg = nullptr;

// Accepts only an at+jwt token, should fail with COMPAT token
while (rv == 0 && status) {
rv = scitoken_deserialize_continue(&scitoken, &status, &err_msg);
EXPECT_FALSE(rv == 0) << err_msg;
free(err_msg);
err_msg = nullptr;
}
}

Expand All @@ -452,6 +471,7 @@ TEST_F(SerializeTest, ExplicitTime) {

rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(token_value);
ASSERT_TRUE(rv == 0) << err_msg;

auto enforcer = enforcer_create("https://demo.scitokens.org/gtest",
Expand All @@ -461,18 +481,23 @@ TEST_F(SerializeTest, ExplicitTime) {
rv = enforcer_generate_acls(enforcer, m_read_token.get(), &acls, &err_msg);
ASSERT_TRUE(rv == 0) << err_msg;
ASSERT_TRUE(acls != nullptr);
enforcer_acl_free(acls);

enforcer_set_time(enforcer, time(NULL), &err_msg);
rv = enforcer_generate_acls(enforcer, m_read_token.get(), &acls, &err_msg);
ASSERT_TRUE(rv == 0) << err_msg;

enforcer_set_time(enforcer, time(NULL) + 100, &err_msg);
enforcer_acl_free(acls);
rv = enforcer_generate_acls(enforcer, m_read_token.get(), &acls, &err_msg);
free(err_msg);
err_msg = nullptr;
ASSERT_FALSE(rv == 0);

enforcer_set_time(enforcer, time(NULL) - 100, &err_msg);
rv = enforcer_generate_acls(enforcer, m_read_token.get(), &acls, &err_msg);
ASSERT_FALSE(rv == 0);
free(err_msg);

enforcer_destroy(enforcer);
}
Expand Down Expand Up @@ -554,6 +579,7 @@ TEST_F(SerializeNoKidTest, VerifyATJWTTest) {
SciTokenProfile::SCITOKENS_2_0);
rv = scitoken_deserialize_v2(token_value, m_read_token.get(), nullptr,
&err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand Down Expand Up @@ -611,6 +637,7 @@ TEST_F(KeycacheTest, RefreshInvalid) {
auto rv =
keycache_refresh_jwks("https://demo.scitokens.org/invalid", &err_msg);
ASSERT_FALSE(rv == 0);
free(err_msg);

rv = keycache_get_cached_jwks("https://demo.scitokens.org/invalid", &jwks,
&err_msg);
Expand Down Expand Up @@ -703,10 +730,13 @@ TEST_F(KeycacheTest, InvalidConfigKeyTest) {
std::string key = "invalid key";
auto rv =
scitoken_config_set_int(key.c_str(), new_update_interval, &err_msg);
free(err_msg);
err_msg = nullptr;
ASSERT_FALSE(rv == 0);

const char *key2 = nullptr;
rv = scitoken_config_set_int(key2, new_update_interval, &err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand Down Expand Up @@ -740,6 +770,7 @@ TEST_F(KeycacheTest, SetInvalidUpdateTest) {
std::string key = "keycache.update_interval_s";
auto rv =
scitoken_config_set_int(key.c_str(), new_update_interval, &err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand All @@ -749,6 +780,7 @@ TEST_F(KeycacheTest, SetInvalidExpirationTest) {
std::string key = "keycache.expiration_interval_s";
auto rv =
scitoken_config_set_int(key.c_str(), new_expiration_interval, &err_msg);
free(err_msg);
ASSERT_FALSE(rv == 0);
}

Expand Down
Loading