Skip to content

Conversation

@djw8605
Copy link
Contributor

@djw8605 djw8605 commented Jan 4, 2019

No description provided.

@djw8605 djw8605 requested a review from bbockelm January 4, 2019 01:41
@bbockelm
Copy link
Contributor

bbockelm commented Jan 4, 2019

Not entirely clear that's the best way to find libcrypto on OS X. Regardless, merging it to move forward.

Can you google around a little bit to see if there are other solutions that don't involve hardcoding?

@bbockelm bbockelm merged commit 1e1a677 into scitokens:master Jan 4, 2019
@djw8605 djw8605 deleted the mac-support branch January 4, 2019 17:29
@djw8605
Copy link
Contributor Author

djw8605 commented Jan 4, 2019

I googled around a ton to find how to link to openssl and get headers. I couldn't find anything helpful. Everything suggested installed homebrew.

The final libraries though do link to the system's libcrypto:

$ otool -L libSciTokens.0.dylib 
libSciTokens.0.dylib:
	/Users/derekweitzel/git/scitokens-cpp/build/libSciTokens.0.dylib (compatibility version 0.0.0, current version 0.0.2)
	/usr/lib/libcrypto.35.dylib (compatibility version 36.0.0, current version 36.0.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/usr/lib/libsqlite3.dylib (compatibility version 9.0.0, current version 274.20.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.4)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)

So the binaries are distributable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants