Skip to content

Conversation

@brianhlin
Copy link
Contributor

Per @bbockelm

Copy link
Contributor

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested? A few lines below at

me->m_gen_acls.emplace_back("condor", "/WRITE");

It uses /WRITE with the slash, which makes sense given it's a path.

@bbockelm
Copy link
Contributor

bbockelm commented Jun 3, 2021

Yeah, should be /READ

@brianhlin
Copy link
Contributor Author

Ah, right. Fixed. This did however fix the issue I was having so maybe there's some path normalization occurring further down the line?

Copy link
Contributor

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw8605 djw8605 merged commit 7d9c77b into scitokens:master Jun 3, 2021
@brianhlin brianhlin deleted the fixup-condor-read branch October 6, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants