Adding UUID for jti generation #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
reviewed
Jan 8, 2019
Contributor
bbockelm
left a comment
bbockelm
left a comment
There was a problem hiding this comment.
Just some really trivial whitespace changes to match the surrounding text (or to make the line consistent in the first place).
Should be able to approve them all through the GitHub UI, I think.
cmake/FindUUID.cmake
Outdated
| # show the UUID_INCLUDE_DIRS and UUID_LIBRARIES variables only in the advanced view | ||
| mark_as_advanced(UUID_INCLUDE_DIRS UUID_LIBRARIES) | ||
|
|
||
| endif (UUID_SYMBOL) No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| endif (UUID_SYMBOL) | |
| endif (UUID_SYMBOL) |
(add EOL -- not sure if GitHub suggestion interface adds this correctly...)
Contributor
Author
There was a problem hiding this comment.
It doesn't, but I added the new line.
Co-Authored-By: djw8605 <djw8605@gmail.com>
Co-Authored-By: djw8605 <djw8605@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.