Use double layer of const for deserialize #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using const char** does not allow implicit conversion from char**. It has to be protected at both level of de-reference, so: char const* const*
Contributor
|
Looks good to me. What precisely was the use case that hit this issue though? |
Contributor
Author
|
This line caused a compile error:
https://github.com/cvmfs-contrib/cvmfs-x509-helper/blob/master/src/scitoken_helper_check.cc#L83
The null terminated list is char**
https://github.com/cvmfs-contrib/cvmfs-x509-helper/blob/e2a94b338b514149fd8d54b753db8cf73f32b2d1/src/scitoken_helper_check.cc#L83
-Derek
… On May 14, 2019, at 8:55 PM, Brian P Bockelman ***@***.***> wrote:
Looks good to me. What precisely was the use case that hit this issue though?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
const char**does not allow implicit conversion fromchar**. It has to be protected at both level of de-reference:char const* const*