🔧 using common strings is now the default#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to manually enable common strings appears to be one of the biggest unexpected behaviors, leading to plenty of questions.
Making the use of common strings a default does not fix all problems (e.g., people wanting to get non-interpolated, string values), but it should be a crucial first step and - most importantly - makes the default config more natural and intuitive for new users.
Not many negative side effects are expected from this. The old behavior can easily be enabled by creating a parser with
common_strings=FalseFixes #280
Fixes #263
Fixes #248