Fix atlasian and JIRA cloud login

[phracek]

Summary by CodeRabbit

• Build Updates

  • Container images for daily tests and eol checker updated to version 0.10.4
  • Build targets restructured for improved maintainability

• Improvements

  • Enhanced error handling in Jira integration for more robust ticket retrieval
  • Updated Jira authentication configuration

[coderabbitai]

Warning

Review limit reached

@phracek, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02030cc8-dc53-44eb-8a1c-5d98343437d0

📥 Commits

Reviewing files that changed from the base of the PR and between e2a349f and b4eff65.

📒 Files selected for processing (2)

• eol-checker/eol_checker/jira.py
• eol-checker/tests/test_jira.py

📝 Walkthrough

Walkthrough

Version 0.10.4 is bumped across Dockerfile environment variables, workflow Quay tags, and Makefile build targets. The Makefile reorganizes image builds into separate targets. The eol-checker refactors Jira authentication to use token-based credentials and adds HTTP error handling. Checker initialization removes direct debug flag assignment and sets up email formatting state.

Changes

Build Infrastructure and eol-checker Refactoring

Layer / File(s)	Summary
Build infrastructure version coordination Dockerfile.daily-tests, Dockerfile.eol-checker, .github/workflows/build-and-push.yml, Makefile	Container image version is bumped from 0.10.3 to 0.10.4 across Dockerfile RELEASE_UPSTREAM variables, Quay.io tags in workflow jobs, and Makefile podman build commands. The Makefile also restructures build targets by splitting daily_tests and eol_checker into separate targets that build_images now depends on.
Jira client authentication and error handling eol-checker/eol_checker/jira.py	JiraFetcher.jira property now reads JIRA_TOKEN and JIRA_USERNAME from environment variables, initializes the Jira client with cloud=True, and validates credential presence. get_jira_deprecation_details wraps issue fetching in try/except HTTPError, logs the ticket key at debug level, and treats HTTP errors as caught exceptions rather than allowing propagation.
Checker initialization and email state setup eol-checker/eol_checker/checker.py	ContainerEolChecker.init removes the self.debug assignment in favor of debug-enabled logic passed to _setup_logger, and initializes email formatting variables (bold_line, bold_line_end, mime_msg, body) for later report generation.

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• sclorg/ci-scripts#229: Overlaps on eol-checker/eol_checker/checker.py email/report body MIME handling and message state initialization.
• sclorg/ci-scripts#231: Directly precedes this PR's checker.py debug/logging refactor by introducing debug-enabled logic in __init__ and _setup_logger.
• sclorg/ci-scripts#226: Shares image/version tag updates for upstream-daily-tests across Dockerfile, Makefile, and workflow files.

Suggested labels

ready for review

Poem

🐰 A rabbit hops through versions with glee,
From 0.10.3 to .4, can't you see?
Jira tokens flow secure and true,
Email states initialized anew,
Docker, Makefile, all sync'd through the queue! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is partially related to the changeset but incomplete. While the PR does include JIRA authentication fixes, it also contains multiple unrelated changes (Docker image version bumps from 0.10.3 to 0.10.4, Makefile target refactoring) that are not mentioned in the title.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.16%. Comparing base (577424e) to head (b4eff65).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
eol-checker/eol_checker/jira.py	68.75%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   62.42%   62.16%   -0.26%     
==========================================
  Files          13       13              
  Lines        1344     1348       +4     
==========================================
- Hits          839      838       -1     
- Misses        505      510       +5     

Flag	Coverage Δ
daily-tests-unit	44.26% <ø> (ø)
eol-checker-unit	95.90% <68.75%> (-1.44%)	⬇️
ocp-stream-generator-unit	84.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
eol-checker/eol_checker/checker.py	98.87% <ø> (-0.01%)	⬇️
eol-checker/eol_checker/jira.py	91.93% <68.75%> (-8.07%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@eol-checker/eol_checker/jira.py`:
- Line 29: The debug log in jira.py prints the sensitive variable jira_token;
remove that token logging and replace it with a non-sensitive message (e.g., log
that a token was provided or log only its length/hex-masked form) so credentials
are never written to logs. Locate the logger.debug call that references
jira_token and either delete it or change it to a redacted/metadata-only message
(no raw token value) in the function/module that initializes JIRA
authentication.
- Around line 50-55: The code calls self.jira.issue(...) without checking that
the jira client exists, causing an AttributeError when JIRA_TOKEN/JIRA_USERNAME
are missing; update the try block in the method that uses self.jira (where
jira_deprecation_ticket is referenced) to first guard against None by checking
if self.jira is truthy and if not, log a clear message and skip calling
self.jira.issue; keep the existing HTTPError exception handling for real HTTP
failures and ensure self.jira_details is only assigned when issue is retrieved.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 30f6e69d-c8bd-4d37-994e-387521324a5d

📥 Commits

Reviewing files that changed from the base of the PR and between 577424e and e2a349f.

📒 Files selected for processing (6)

• .github/workflows/build-and-push.yml
• Dockerfile.daily-tests
• Dockerfile.eol-checker
• Makefile
• eol-checker/eol_checker/checker.py
• eol-checker/eol_checker/jira.py

💤 Files with no reviewable changes (1)

• eol-checker/eol_checker/checker.py