Skip to content

(fix): Use end of line anchor on sed to make it idempotent#290

Merged
notroj merged 1 commit intosclorg:masterfrom
taylor-benson:bugfix/common-shell-sed-fix
Apr 15, 2026
Merged

(fix): Use end of line anchor on sed to make it idempotent#290
notroj merged 1 commit intosclorg:masterfrom
taylor-benson:bugfix/common-shell-sed-fix

Conversation

@taylor-benson
Copy link
Copy Markdown
Contributor

@taylor-benson taylor-benson commented Apr 13, 2026

Fixes #289

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - RHEL9 - PyTest - OpenShift 4 - 2.4[pending]
  • Testing Farm - RHEL10 - PyTest - OpenShift 4 - 2.4[pending]
  • Testing Farm - RHEL8 - PyTest - OpenShift 4 - 2.4[pending]

Success

🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

@notroj
Copy link
Copy Markdown
Contributor

notroj commented Apr 14, 2026

[test][test-pytest][test-openshift-pytest]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - 2.4Fedora-latestx86_64✅ passed14.04.2026 15:54:107min 31stest pipeline
Fedora - PyTest - 2.4-microFedora-latestx86_64✅ passed14.04.2026 15:54:097min 58stest pipeline
Fedora - 2.4-microFedora-latestx86_64✅ passed14.04.2026 15:54:137min 59stest pipeline
Fedora - 2.4Fedora-latestx86_64✅ passed14.04.2026 15:54:108min 28stest pipeline
CentOS Stream 9 - 2.4-microCentOS-Stream-9x86_64✅ passed14.04.2026 15:54:1211min 2stest pipeline
CentOS Stream 10 - PyTest - 2.4CentOS-Stream-10x86_64✅ passed14.04.2026 15:54:1310min 3stest pipeline
CentOS Stream 9 - PyTest - 2.4-microCentOS-Stream-9x86_64✅ passed14.04.2026 15:54:1110min 57stest pipeline
CentOS Stream 10 - 2.4-microCentOS-Stream-10x86_64✅ passed14.04.2026 15:54:1011min 16stest pipeline
RHEL8 - PyTest - 2.4RHEL-8.10.0-Nightlyx86_64✅ passed14.04.2026 15:54:1314min 24stest pipeline
RHEL8 - 2.4RHEL-8.10.0-Nightlyx86_64✅ passed14.04.2026 15:54:1315min 2stest pipeline
RHEL10 - 2.4RHEL-10.2-Nightlyx86_64✅ passed14.04.2026 15:54:1017min 42stest pipeline
RHEL10 - Unsubscribed host - PyTest - 2.4RHEL-10.2-Nightlyx86_64✅ passed14.04.2026 15:54:1317min 49stest pipeline
RHEL10 - Unsubscribed host - 2.4RHEL-10.2-Nightlyx86_64✅ passed14.04.2026 15:54:1216min 49stest pipeline
CentOS Stream 9 - PyTest - 2.4CentOS-Stream-9x86_64✅ passed14.04.2026 16:02:269min 32stest pipeline
CentOS Stream 9 - 2.4CentOS-Stream-9x86_64✅ passed14.04.2026 16:02:369min 40stest pipeline
RHEL10 - PyTest - 2.4RHEL-10.2-Nightlyx86_64✅ passed14.04.2026 15:54:1118min 37stest pipeline
RHEL9 - Unsubscribed host - PyTest - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed14.04.2026 15:54:1319min 55stest pipeline
RHEL9 - PyTest - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed14.04.2026 15:54:1020min 29stest pipeline
RHEL9 - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed14.04.2026 15:54:3123min 17stest pipeline
RHEL8 - PyTest - OpenShift 4 - 2.4RHEL-8.10.0-Nightlyx86_64✅ passed15.04.2026 10:22:1219min 56stest pipeline
RHEL10 - PyTest - OpenShift 4 - 2.4RHEL-10.2-Nightlyx86_64✅ passed15.04.2026 10:22:1122min 44stest pipeline
RHEL9 - PyTest - OpenShift 4 - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed15.04.2026 10:22:1025min 45stest pipeline

@phracek
Copy link
Copy Markdown
Member

phracek commented Apr 15, 2026

/auto-merge

Copy link
Copy Markdown
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notroj notroj merged commit 5b15d82 into sclorg:master Apr 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httpd-prepare: config_general() Listen port substitution is not idempotent

3 participants