Container PyTest suite for mysql-container#421
Merged
phracek merged 10 commits intosclorg:masterfrom Mar 17, 2026
Merged
Conversation
Pull Request validationFailed🔴 Approval - missing or changes were requested Success🟢 CI - All checks have passed |
Testing Farm results
|
phracek
force-pushed
the
container_pytests
branch
from
1469234 to
8e81f48
Compare
Member
Author
|
[test][test-pytest] |
phracek
force-pushed
the
container_pytests
branch
from
4399661 to
5639d0e
Compare
phracek
force-pushed
the
container_pytests
branch
2 times, most recently
from
c42cf2a to
0b9003c
Compare
Member
Author
|
@frenzymadness I have rewritten this pull request based on the already reviewed mariadb-container PR sclorg/mariadb-container#311. So it should be easier ;) |
phracek
force-pushed
the
container_pytests
branch
from
2d25558 to
4a285e3
Compare
Member
Author
|
[test-all] |
frenzymadness
requested changes
Mar 10, 2026
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
First round done. Thank you for being so patient.
github-actions
bot
added
pr/failing-ci
pr/changes-requested
and removed
pr/missing-review
pr/failing-ci
labels
Member
|
I've reported the |
phracek
force-pushed
the
container_pytests
branch
2 times, most recently
from
d322b6f to
b6a9d8b
Compare
Migration matrix is here: - run_container_creation_tests -> test_container_configuration.py - run_configuration_tests -> test_container_configuration.py - run_general_tests -> test_container_general.py - run_change_password_test -> test_container_password.py - run_change_password_new_user_test -> test_container_password.py - run_replication_test -> Not Yet - run_s2i_test -> test_container_basics.py - run_ssl_test -> test_container_ssl.py - run_datadir_actions_test -> test_container_general.py Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Check configuration files in one command instead of several ones. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
sclorg/mariadb-container#311 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
version Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Update also test_replication.py file (pre-commit issues) Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Use conftest.py and VARS tuple from this. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Use variable TEST_DIR instead of again definition. Check if both variables asserts. Use and operator Use already defined variable instead of hardcoding them Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com> Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
done by @frenzymadness Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
container_pytests
branch
from
b6a9d8b to
d9532f0
Compare
Member
Author
|
Rebased agains master [test-pytest] |
Member
Author
|
@frenzymadness Can I please ask you for one more review? Thanks |
frenzymadness
approved these changes
Mar 17, 2026
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
I'm not going to pretend I understand all the tests (the one changing passwords are super confusing to me), but I think this is good enough to be merged and improved in the future, if required.
I've identified one possible idea to simplify future maintenance, but feel free to ignore it or implement it later when needed.
Comment on lines
+12
to
+16
| TAGS = { | ||
| "rhel8": "-el8", | ||
| "rhel9": "-el9", | ||
| "rhel10": "-el10", | ||
| } |
Member
There was a problem hiding this comment.
Idea: Turn this into a function containing just tag.replace("rh", "-", 1) - that way, you'll never have to add anything here manually.
Member
Author
There was a problem hiding this comment.
This could be a part of container-ci-suite directly. Good point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container PyTest suite for mysql-container
Migration matrix is here: