Compare sizes only for RHEL 10 and higher. No less OS#377
Merged
phracek merged 1 commit intosclorg:masterfrom Apr 21, 2026
Merged
Compare sizes only for RHEL 10 and higher. No less OS#377phracek merged 1 commit intosclorg:masterfrom
phracek merged 1 commit intosclorg:masterfrom
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
📝 WalkthroughWalkthroughThe test file is refactored to extract Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/test_container_sizes.py (1)
36-40: Prefer a threshold check over enumerating old RHEL releases.The requirement is “RHEL 10 and higher,” but the code hard-codes
rhel7/rhel8/rhel9. Comparing the parsed major version makes the intent clearer and avoids stale skip logic if another pre-10 value appears.♻️ Proposed refactor
- if previous_os_version in ["rhel7", "rhel8", "rhel9"]: - pytest.skip("Skipping container size comparison for RHEL 7, 8 and 9.") + previous_os_major = int(previous_os_version[len("rhel") :]) + if previous_os_major < 10: + pytest.skip("Skipping container size comparison against pre-RHEL 10 images.")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/test_container_sizes.py` around lines 36 - 40, The test currently skips specific strings ("rhel7", "rhel8", "rhel9") which can become stale; change the logic in test_container_sizes.py to parse the major version from previous_os_version (e.g., detect the "rhel" prefix, extract the numeric major version) and skip when that major version is < 10 instead of enumerating values; update the block around previous_os_version and the subsequent call to get_public_image_name to use this version check so RHEL 10+ runs while all pre-10 releases are skipped.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@test/test_container_sizes.py`:
- Around line 36-40: The test currently skips specific strings ("rhel7",
"rhel8", "rhel9") which can become stale; change the logic in
test_container_sizes.py to parse the major version from previous_os_version
(e.g., detect the "rhel" prefix, extract the numeric major version) and skip
when that major version is < 10 instead of enumerating values; update the block
around previous_os_version and the subsequent call to get_public_image_name to
use this version check so RHEL 10+ runs while all pre-10 releases are skipped.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 08d265ba-9e21-440d-9041-ecddafd2aa31
📒 Files selected for processing (1)
test/test_container_sizes.py
Member
Author
|
[test-pytest] |
Testing Farm results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit